Re: [pgAdmin][Patch] RM4226 - Table Properties - select all checkbox only selects the first 50 tables

From: Yogesh Mahajan <yogesh(dot)mahajan(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Cc: Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>
Subject: Re: [pgAdmin][Patch] RM4226 - Table Properties - select all checkbox only selects the first 50 tables
Date: 2020-06-15 13:27:13
Message-ID: CAMa=N=OhX+p0E-uteJt9AO9tzrR83sk+HXVPSYODipVqBZkL8g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Hackers,

Please find an updated patch.

Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709

On Mon, Jun 15, 2020 at 3:52 PM Khushboo Vashi <
khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:

> Hi Yogesh,
>
> this.data.splice is not required as you are adding the entire dataset into collection.
>
> Thanks,
>
> Khushboo
>
>
> On Mon, Jun 15, 2020 at 3:01 PM Yogesh Mahajan <
> yogesh(dot)mahajan(at)enterprisedb(dot)com> wrote:
>
>> Hi Hackers,
>>
>> Please find attached patch fixing behaviour on checking select-all
>> checkbox from properties tab for more than 50 entities.
>>
>> Thanks,
>> Yogesh Mahajan
>> QA - Team
>> EnterpriseDB Corporation
>>
>> Phone: +91-9741705709
>>
>

Attachment Content-Type Size
RM4226_v2.patch application/octet-stream 1.1 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Khushboo Vashi 2020-06-16 02:52:22 Re: Patch for SonarQube UI fixes.
Previous Message Yogesh Mahajan 2020-06-15 13:12:52 [pgAdmin4][Patch] - Issue fixes reported by SonarQube