Re: [pgAdmin 4][Patch] - Cloud Deployment - Fixed Review Comments

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin 4][Patch] - Cloud Deployment - Fixed Review Comments
Date: 2022-06-09 08:39:20
Message-ID: CANxoLDetP1Vavf=FjJkqy-dA_hjPmEF4fW+5vH8=cccG5aA2_Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, the patch applied.

On Thu, Jun 9, 2022 at 11:53 AM Khushboo Vashi <
khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:

> Hi Akshay,
>
> Please find the attached updated patch.
>
> On Wed, Jun 8, 2022 at 3:56 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
> wrote:
>
>> Hi Khushboo
>>
>> Please fix the pep8, linter, and jasmine test cases.
>>
> Fixed.
>
> Thanks,
> Khushboo
>
>>
>> On Wed, Jun 8, 2022 at 1:35 PM Khushboo Vashi <
>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>
>>> Hello,
>>>
>>> Please find the attached patch to fix the review comments given in the
>>> Cloud Deployment demo:
>>>
>>> - Added High Availability option
>>> - Server group renamed to pgAdmin server group
>>> - Removed the Private option from Networking otherwise, it would not be
>>> possible to connect the server from pgAdmin.
>>>
>>> Thanks,
>>> Khushboo
>>>
>>
>>
>> --
>>
>> <http://www.enterprisedb.com>
>>
>> Akshay Joshi
>>
>> Principal Software Architect
>>
>> +91 9767888246
>>
>> www.enterprisedb.com
>>
>> <https://www.linkedin.com/company/edbpostgres>
>> <https://twitter.com/edbpostgres?lang=en>
>> <https://www.facebook.com/EDBpostgres>
>> <https://www.instagram.com/EDBpostgres/>
>>
>

--

<http://www.enterprisedb.com>

Akshay Joshi

Principal Software Architect

+91 9767888246

www.enterprisedb.com

<https://www.linkedin.com/company/edbpostgres>
<https://twitter.com/edbpostgres?lang=en>
<https://www.facebook.com/EDBpostgres>
<https://www.instagram.com/EDBpostgres/>

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Pradip Parkale 2022-06-09 08:47:37 Re: [pgAdmin][RM7351]: Templates not displayed
Previous Message Akshay Joshi 2022-06-09 08:37:59 pgAdmin 4 commit: Fixed some cloud deployment issues: