| From: | Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com> |
|---|---|
| To: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin 4][Patch] - Cloud Deployment - Fixed Review Comments |
| Date: | 2022-06-09 06:23:39 |
| Message-ID: | CAFOhELdEujonE+azpOGvajCBA=gyPKSPbGMp+6WUWVR7y1RrCQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi Akshay,
Please find the attached updated patch.
On Wed, Jun 8, 2022 at 3:56 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:
> Hi Khushboo
>
> Please fix the pep8, linter, and jasmine test cases.
>
Fixed.
Thanks,
Khushboo
>
> On Wed, Jun 8, 2022 at 1:35 PM Khushboo Vashi <
> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Hello,
>>
>> Please find the attached patch to fix the review comments given in the
>> Cloud Deployment demo:
>>
>> - Added High Availability option
>> - Server group renamed to pgAdmin server group
>> - Removed the Private option from Networking otherwise, it would not be
>> possible to connect the server from pgAdmin.
>>
>> Thanks,
>> Khushboo
>>
>
>
> --
>
> <http://www.enterprisedb.com>
>
> Akshay Joshi
>
> Principal Software Architect
>
> +91 9767888246
>
> www.enterprisedb.com
>
> <https://www.linkedin.com/company/edbpostgres>
> <https://twitter.com/edbpostgres?lang=en>
> <https://www.facebook.com/EDBpostgres>
> <https://www.instagram.com/EDBpostgres/>
>
| Attachment | Content-Type | Size |
|---|---|---|
| biganimal_review_comments_v1.patch | application/octet-stream | 13.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Akshay Joshi | 2022-06-09 07:16:26 | Re: [pgAdmin][RM7351]: Templates not displayed |
| Previous Message | Pradip Parkale | 2022-06-09 02:07:39 | Re: [pgAdmin][RM7351]: Templates not displayed |