From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
---|---|
To: | Dave Page <dpage(at)pgadmin(dot)org> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [patch] update table name in confirmation dialog for 'Reset Statistics' and 'Truncate Table' |
Date: | 2017-05-18 09:37:18 |
Message-ID: | CANxoLDeqzDysu_e2HS2LQk89Xma0V2rtkUhEbmmunhTth9LTpA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
On Thu, May 18, 2017 at 3:00 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> Hi
>
> Please see the discussion here: https://redmine.postgresql.org/issues/2308
>
> Would moving to the client-side translation mechanism help here? We need
> to do that anyway - and it's been added since the previous discussion.
>
OK, at least we should checked-in code for showing title of the
confirmation dialog for "Truncate".
>
> On Thu, May 18, 2017 at 10:17 AM, Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Hi All
>>
>> I have found one issue where table name is not displaying in the confirmation
>> dialog when user click on "Reset Statistics" and "Truncate/Truncate
>> cascade". Confirmation dialog shows below message:
>>
>> - Are you sure you want to truncate table {}?
>> - Are you sure you want to reset the statistics for table {}?
>>
>> Also header is missing for "Truncate/Truncate cascade" confirmation
>> dialog. Attached is the patch file to fix that above. Please review it.
>>
>> --
>> *Akshay Joshi*
>> *Principal Software Engineer *
>>
>>
>>
>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 976-788-8246
>> <+91%2097678%2088246>*
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
--
*Akshay Joshi*
*Principal Software Engineer *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2017-05-18 09:53:12 | Re: [patch] update table name in confirmation dialog for 'Reset Statistics' and 'Truncate Table' |
Previous Message | Dave Page | 2017-05-18 09:31:06 | Re: [pgAdmin4] [PATCH] History Tab rewrite in React |