Re: [pgAdmin4] [PATCH] History Tab rewrite in React

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
Cc: Matthew Kleiman <mkleiman(at)pivotal(dot)io>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Shruti B Iyer <siyer(at)pivotal(dot)io>
Subject: Re: [pgAdmin4] [PATCH] History Tab rewrite in React
Date: 2017-05-18 09:31:06
Message-ID: CA+OCxow3e=q9w_e=Kkw1ebZJ82EM8RyFmiTaXihdqhX6HbzZhw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

On Thu, May 18, 2017 at 9:56 AM, Murtuza Zabuawala <murtuza.zabuawala@
enterprisedb.com> wrote:

>
> Go to 'pgadmin4/web' directory
>
> Try running,
>
> run 'yarn install'
>
> (if you have installed globally)
> then run 'grunt'
> OR
> run './node_modules/grunt-cli/bin/grunt'
>
>
> Then run pgAdmin4
>

OK, that worked - though pgAdmin now takes a lot longer to start up, which
is a problem.

The Jasmine tests now fail:

(pgadmin4)piranha:web dpage$ yarn run karma start --single-run
yarn run v0.24.4
$ "/Users/dpage/git/pgadmin4/web/node_modules/.bin/karma" start
18 05 2017 10:22:01.182:ERROR [plugin]: Error during loading
"karma-phantomjs-launcher" plugin:
Path must be a string. Received null

webpack: Compiled successfully.
webpack: Compiling...
webpack: wait until bundle finished:
webpack: wait until bundle finished:
webpack: wait until bundle finished:
webpack: wait until bundle finished:
webpack: wait until bundle finished:
webpack: wait until bundle finished:
webpack: wait until bundle finished:
webpack: wait until bundle finished:
webpack: wait until bundle finished:
webpack: wait until bundle finished:
webpack: wait until bundle finished:
webpack: wait until bundle finished:
(node:12214) DeprecationWarning: loaderUtils.parseQuery() received a
non-string value which can be problematic, see https://github.com/webpack/
loader-utils/issues/56
parseQuery() will be replaced with getOptions() in the next major version
of loader-utils.
18 05 2017 10:22:07.281:WARN [karma]: No captured browser, open
http://localhost:9876/

webpack: Compiled successfully.
18 05 2017 10:22:07.294:ERROR [karma]: Found 1 load error
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this
command.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2017-05-18 09:37:18 Re: [patch] update table name in confirmation dialog for 'Reset Statistics' and 'Truncate Table'
Previous Message Dave Page 2017-05-18 09:30:46 Re: [patch] update table name in confirmation dialog for 'Reset Statistics' and 'Truncate Table'