Re: [pgAdmin4][RM3865] Difficult to resize Query Tool

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Dave Page <dave(dot)page(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
Subject: Re: [pgAdmin4][RM3865] Difficult to resize Query Tool
Date: 2019-01-30 09:17:23
Message-ID: CANxoLDehxm2pfHNjdU2D7HysO4+0vge0_F7S8MpB-Sr8aZCQPw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Dave

On Wed, Jan 30, 2019 at 2:32 PM Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
wrote:

> Hi Dave,
>
> I was having conversation with Aditya about "What should be the mouse
> hover (resize selection) area of the splitters?".
> I asked him to set it to 5px.
>

I have committed with 7px which looks good, but it would be good to
have your opinion on this. You will have to run "Yarn Install" to test
this.

>
> But - he has different opinion, was in favor to keep it around '11px'.
>
> Please advise.
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> <http://www.enterprisedb.com>
>
>
> *http://www.linkedin.com/in/asheshvashi*
> <http://www.linkedin.com/in/asheshvashi>
>
>
> On Wed, Jan 30, 2019 at 12:32 PM Aditya Toshniwal <
> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>
>> Hi Hackers,
>>
>> With my pull request for changes in wcDocker merged (
>> https://github.com/EnterpriseDB/wcDocker/commit/9cf81f03bb350b76b77a264f1db5d55391d5e424),
>> we are now able to increase the mouse hover area of the frame splitters
>> without increasing visible splitter lines width.
>> Attached is the patch for changes required in pgAdmin accordingly. I have
>> kept the total hover width as $splitter-hover-width:5px, which can be
>> changed.
>>
>> Kindly review.
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Software Engineer | EnterpriseDB Software Solutions | Pune
>> "Don't Complain about Heat, Plant a tree"
>>
>

--
*Akshay Joshi*

*Sr. Software Architect *

*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2019-01-30 09:19:06 pgAdmin 4 commit: Fixed debugger issue for procedure inside package for
Previous Message Ashesh Vashi 2019-01-30 09:01:58 Re: [pgAdmin4][RM3865] Difficult to resize Query Tool