Re: [pgAdmin][RM5154] [Accessibility] : Alertify

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
Cc: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Pradip Parkale <pradip(dot)parkale(at)enterprisedb(dot)com>
Subject: Re: [pgAdmin][RM5154] [Accessibility] : Alertify
Date: 2020-02-21 05:49:37
Message-ID: CANxoLDeefWqrFZHSyTE4Ugh2Dity0cUwoHNaMZemtRnqt-pfEA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Aditya

Can you please review this patch.

On Wed, Feb 19, 2020 at 5:04 PM Pradip Parkale <
pradip(dot)parkale(at)enterprisedb(dot)com> wrote:

> Please find the attached patch.
>
> On Wed, Feb 19, 2020 at 5:02 PM Ashesh Vashi <
> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Forgot to attach the patch?
>>
>> On Wed, 19 Feb 2020 at 16:58, Pradip Parkale <
>> pradip(dot)parkale(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached is a patch for accessibility issue related Alertifyjs.
>>>
>>> 1. Added hidden label to satisfy accessibility.
>>> 2. Added label with sr-only class.
>>> 3. Added tabindex to move the mouse control to the maximize button
>>> using the tab key.
>>>
>>>
>>> Please note that this patch also includes the fix for the
>>> RM-5143 Accessibility issue to maximize the panel for backup and restore
>>> windows and all other places.
>>> --
>>> Thanks & Regards,
>>> Pradip Parkale
>>> QMG, EnterpriseDB Corporation
>>>
>> --
>>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>> <http://www.enterprisedb.com>
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*
>> <http://www.linkedin.com/in/asheshvashi>
>>
>
>
> --
> Thanks & Regards,
> Pradip Parkale
> QMG, EnterpriseDB Corporation
>

--
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2020-02-21 07:45:38 Re: [pgAdmin][RM5133] UI Improvements for White and Dark Theme
Previous Message Aditya Toshniwal 2020-02-20 07:36:39 [pgAdmin][RM5133] UI Improvements for White and Dark Theme