Re: [pgAdmin][RM5154] [Accessibility] : Alertify

Hi Pradip,

-
commonUtils.findAndSetFocus($(alertifyDialog.elements.body).find('.tab-content
div.active'));
+
$(alertifyDialog.elements.dialog).find('[tabindex]:not([tabindex="-1"]').first().focus();

Use the same common function with
commonUtils.findAndSetFocus(alertifyDialog.elements.dialog)). It will
handle the focus.
Also, make the required changes mentioned on the pull request -
https://github.com/EnterpriseDB/AlertifyJS/pull/1

On Fri, Feb 21, 2020 at 11:19 AM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:

> Hi Aditya
>
> Can you please review this patch.
>
> On Wed, Feb 19, 2020 at 5:04 PM Pradip Parkale <
> pradip(dot)parkale(at)enterprisedb(dot)com> wrote:
>
>> Please find the attached patch.
>>
>> On Wed, Feb 19, 2020 at 5:02 PM Ashesh Vashi <
>> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>>
>>> Forgot to attach the patch?
>>>
>>> On Wed, 19 Feb 2020 at 16:58, Pradip Parkale <
>>> pradip(dot)parkale(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi Hackers,
>>>>
>>>> Attached is a patch for accessibility issue related Alertifyjs.
>>>>
>>>> 1. Added hidden label to satisfy accessibility.
>>>> 2. Added label with sr-only class.
>>>> 3. Added tabindex to move the mouse control to the maximize button
>>>> using the tab key.
>>>>
>>>>
>>>> Please note that this patch also includes the fix for the
>>>> RM-5143 Accessibility issue to maximize the panel for backup and restore
>>>> windows and all other places.
>>>> --
>>>> Thanks & Regards,
>>>> Pradip Parkale
>>>> QMG, EnterpriseDB Corporation
>>>>
>>> --
>>>
>>> --
>>>
>>> Thanks & Regards,
>>>
>>> Ashesh Vashi
>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>>> <http://www.enterprisedb.com>
>>>
>>>
>>> *http://www.linkedin.com/in/asheshvashi*
>>> <http://www.linkedin.com/in/asheshvashi>
>>>
>>
>>
>> --
>> Thanks & Regards,
>> Pradip Parkale
>> QMG, EnterpriseDB Corporation
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>

--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"