| From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
|---|---|
| To: | Rahul Shirsat <rahul(dot)shirsat(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin][RM3851] Add proper indentation to the code when generating a stored procedure |
| Date: | 2020-06-25 06:51:37 |
| Message-ID: | CANxoLDeamkgfaR0KFROdasOMxE6fKZUf7tD19NhFGMnwV6z8hA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi Rahul
I have tested your patch and the issue is not fixed. Create one Procedure,
Function, and Trigger Function using below code *without* applying your
patch:
BEGIN
SELECT 1;
END;
Then apply your patch and check the SQL tab.
On Wed, Jun 24, 2020 at 12:41 AM Rahul Shirsat <
rahul(dot)shirsat(at)enterprisedb(dot)com> wrote:
> Hi Hackers,
>
> Please find the attached patch which fixes pg/ppas issues listed below:
>
> 1. Stored procedure code indentation.
> 2. Functions code indentation.
> 3. Trigger Functions code indentation.
>
> Please review.
>
> --
> *Rahul Shirsat*
> Software Engineer | EnterpriseDB Corporation.
>
--
*Thanks & Regards*
*Akshay Joshi*
*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Yogesh Mahajan | 2020-06-25 06:55:15 | [pgAdmin4][Patch] - SonarQube Issues - 6 (A conditionally executed single line should be denoted by indentation, A "while" loop should be used instead of a "for" loop, Variables should be declared explicitly) |
| Previous Message | Yogesh Mahajan | 2020-06-25 06:21:57 | Re: [pgAdmin4][Patch] - SonarQube Issues - 5 (Rule Boolean checks should not be inverted, Comma operator should not be used) |