From: | Rahul Shirsat <rahul(dot)shirsat(at)enterprisedb(dot)com> |
---|---|
To: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin][RM3851] Add proper indentation to the code when generating a stored procedure |
Date: | 2020-06-26 20:20:27 |
Message-ID: | CAKtn9dNY3xWNp3Qkr5M9xAuGVNMfjkvU=SxeSDNU0n9nkjdBGg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Akshay,
I have made the relevant changes for existing and the new procedure,
functions & triggers.
Please find the patch.
On Thu, Jun 25, 2020 at 12:21 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:
> Hi Rahul
>
> I have tested your patch and the issue is not fixed. Create one Procedure,
> Function, and Trigger Function using below code *without* applying your
> patch:
> BEGIN
> SELECT 1;
> END;
>
> Then apply your patch and check the SQL tab.
>
> On Wed, Jun 24, 2020 at 12:41 AM Rahul Shirsat <
> rahul(dot)shirsat(at)enterprisedb(dot)com> wrote:
>
>> Hi Hackers,
>>
>> Please find the attached patch which fixes pg/ppas issues listed below:
>>
>> 1. Stored procedure code indentation.
>> 2. Functions code indentation.
>> 3. Trigger Functions code indentation.
>>
>> Please review.
>>
>> --
>> *Rahul Shirsat*
>> Software Engineer | EnterpriseDB Corporation.
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>
--
*Rahul Shirsat*
Software Engineer | EnterpriseDB Corporation.
Attachment | Content-Type | Size |
---|---|---|
RM3851_v2.patch | application/octet-stream | 43.5 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Rahul Shirsat | 2020-06-28 15:51:49 | Re: [pgAdmin][RM3851] Add proper indentation to the code when generating a stored procedure |
Previous Message | Akshay Joshi | 2020-06-26 13:55:20 | pgAdmin 4 commit: Fixed an issue where the semicolon is misplaced in RL |