[pgAdmin4][Patch] RM #3277 Runtime startup error handling is broken on Windows

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: [pgAdmin4][Patch] RM #3277 Runtime startup error handling is broken on Windows
Date: 2018-05-31 08:52:52
Message-ID: CANxoLDeYWN9j5VjWmY-HxZK2R8-kNmw5=wHw8LkZmV=r7dAWxw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Hackers,

Attached is the patch file to fix RM #3277 Runtime startup error handling
is broken on Windows. I have figure out the crash at the following call of
Server.cpp(line no 326):

PyRun_SimpleFile(fdopen(PyObject_AsFileDescriptor(PyFileObject),"r"), m_
appfile_utf8.data())

When application exits due to some error it throws *BEX refers to Buffer
Overflow Exception, *when I debug and found that it throws BEX for above
function call. I have replace that call with the following:

PyRun_SimpleFile(cp, m_appfile_utf8.data())

Anyways we have open the file using fopen() at the top of the function then
why to open that again using *fdopen() **in the first call. *

Tested the patch with Python 3.5 and 3.6, please review it.

--
*Akshay Joshi*

*Sr. Software Architect *

*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

Attachment Content-Type Size
RM_3277.patch application/octet-stream 646 bytes

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2018-05-31 09:22:13 pgAdmin 4 commit: Fixed ordering of changes in release note and added o
Previous Message Murtuza Zabuawala 2018-05-31 06:22:19 Re: [pgAdmin4][Patch#3389] To prevent unwanted model changes in Server dialog