Re: [pgAdmin][RM7031]: Database definition wrong

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Pradip Parkale <pradip(dot)parkale(at)enterprisedb(dot)com>
Cc: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin][RM7031]: Database definition wrong
Date: 2021-12-02 10:59:30
Message-ID: CANxoLDeXSMbSeHck-9FB1NL3f3yQg1XGdNZd-xaRj_xH=Cwaxw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, the patch applied.

On Thu, Dec 2, 2021 at 3:09 PM Pradip Parkale <
pradip(dot)parkale(at)enterprisedb(dot)com> wrote:

> Hi Akshay/Aditya,
>
> Please find the updated patch.
>
> On Wed, Dec 1, 2021 at 5:56 PM Aditya Toshniwal <
> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>
>> Hi Pradip,
>>
>> You did not include the server_old table for query_history.
>>
> Fixed.
>
>> Please also remove the commented code:
>> + # db.engine.execute("PRAGMA foreign_keys=ON")
>> +
>> + # db.session.commit()
>> +
>> + # db.engine.execute("PRAGMA foreign_keys=ON")
>> +
>>
> Fixed.
>
>>
>>
>>
>> On Wed, Dec 1, 2021 at 5:25 PM Akshay Joshi <
>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>
>>> Thanks, the patch applied.
>>>
>>> On Wed, Dec 1, 2021 at 4:23 PM Pradip Parkale <
>>> pradip(dot)parkale(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi Hackers,
>>>>
>>>> Please find the attached for #7031 Database definition wrong.
>>>>
>>>> --
>>>> Thanks & Regards,
>>>> Pradip Parkale
>>>> Software Engineer | EnterpriseDB Corporation
>>>>
>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>> *pgAdmin Hacker | Principal Software Architect*
>>> *EDB Postgres <http://edbpostgres.com>*
>>>
>>> *Mobile: +91 976-788-8246*
>>>
>>
>>
>> --
>> Thanks,
>> Aditya Toshniwal
>> pgAdmin Hacker | Software Architect | *edbpostgres.com*
>> <http://edbpostgres.com>
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> Thanks & Regards,
> Pradip Parkale
> Software Engineer | EnterpriseDB Corporation
>

--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2021-12-02 10:59:38 Re: [pgAdmin][7046] Accessibility fixes
Previous Message Akshay Joshi 2021-12-02 10:59:14 pgAdmin 4 commit: Fixed some accessibility issues: