From: | Pradip Parkale <pradip(dot)parkale(at)enterprisedb(dot)com> |
---|---|
To: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
Subject: | Re: [pgAdmin][RM7031]: Database definition wrong |
Date: | 2021-12-02 09:39:29 |
Message-ID: | CAJ9T6SsMhj=XhGmXSZp4Mi6Xcn6e80m8xTts-DBymooWPps+kw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Akshay/Aditya,
Please find the updated patch.
On Wed, Dec 1, 2021 at 5:56 PM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
> Hi Pradip,
>
> You did not include the server_old table for query_history.
>
Fixed.
> Please also remove the commented code:
> + # db.engine.execute("PRAGMA foreign_keys=ON")
> +
> + # db.session.commit()
> +
> + # db.engine.execute("PRAGMA foreign_keys=ON")
> +
>
Fixed.
>
>
>
> On Wed, Dec 1, 2021 at 5:25 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
> wrote:
>
>> Thanks, the patch applied.
>>
>> On Wed, Dec 1, 2021 at 4:23 PM Pradip Parkale <
>> pradip(dot)parkale(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Please find the attached for #7031 Database definition wrong.
>>>
>>> --
>>> Thanks & Regards,
>>> Pradip Parkale
>>> Software Engineer | EnterpriseDB Corporation
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Principal Software Architect*
>> *EDB Postgres <http://edbpostgres.com>*
>>
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin Hacker | Software Architect | *edbpostgres.com*
> <http://edbpostgres.com>
> "Don't Complain about Heat, Plant a TREE"
>
--
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation
Attachment | Content-Type | Size |
---|---|---|
RM7031_v2.patch | application/octet-stream | 5.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Akshay Joshi | 2021-12-02 10:59:14 | pgAdmin 4 commit: Replaced alertifyjs notifiers with React-based notist |
Previous Message | Ashesh Vashi | 2021-12-01 17:44:38 | Re: Patch: Two-factor Authentication (RM #6543) |