| From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
|---|---|
| To: | Dave Page <dpage(at)pgadmin(dot)org> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin4][Patch]: Added some backgrid extensions |
| Date: | 2016-02-26 11:00:49 |
| Message-ID: | CANxoLDeLSAGBTwjJ94NOA5QijD0aYqgWzVoQcvQyZz4qPK-=dg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
On Fri, Feb 26, 2016 at 3:49 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>
> On Thu, Feb 25, 2016 at 3:14 PM, Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Hi All
>>
>> I have added some backgrid extensions like select-all, paginator and
>> filter. This extensions will be required for other modules like Grant
>> Wizard, Data Grid. Attached is the patch file, please review it and let me
>> know the comments if any. If it looks good then please commit the code.
>>
>
> Looks fine, except you forgot to update libraries.txt.
>
> Please fix and I'll commit.
>
Fixed. Attached is the modified patch.
>
> Thanks.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
--
*Akshay Joshi*
*Principal Software Engineer *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
| Attachment | Content-Type | Size |
|---|---|---|
| Backgrid_Extensions_v1.patch | application/octet-stream | 134.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2016-02-26 11:09:07 | pgAdmin 4 commit: Add backgrid extensions for use in various tools: sel |
| Previous Message | Dave Page | 2016-02-26 10:19:55 | Re: [pgAdmin4][Patch]: Added some backgrid extensions |