Re: [pgAdmin4][Patch]: Added some backgrid extensions

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: Added some backgrid extensions
Date: 2016-02-26 10:19:55
Message-ID: CA+OCxowZ-dzPqF5AuwUa_jppAT8nh3CNKyxRzm-OMjrAvL7QKw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Thu, Feb 25, 2016 at 3:14 PM, Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com
> wrote:

> Hi All
>
> I have added some backgrid extensions like select-all, paginator and
> filter. This extensions will be required for other modules like Grant
> Wizard, Data Grid. Attached is the patch file, please review it and let me
> know the comments if any. If it looks good then please commit the code.
>

Looks fine, except you forgot to update libraries.txt.

Please fix and I'll commit.

Thanks.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2016-02-26 11:00:49 Re: [pgAdmin4][Patch]: Added some backgrid extensions
Previous Message Dave Page 2016-02-25 16:47:16 pgAdmin 4 commit: Correct error message to match the field name.