Re: [pgAdmin] RM6098 Manually deleting from table view hangs

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Rahul Shirsat <rahul(dot)shirsat(at)enterprisedb(dot)com>
Cc: Nikhil Mohite <nikhil(dot)mohite(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin] RM6098 Manually deleting from table view hangs
Date: 2021-01-20 07:10:07
Message-ID: CANxoLDeKkRgiLK6L62_LBAyiAME2634LSZ=ds7bnE8n2h-X3PA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, patch applied.

On Tue, Jan 19, 2021 at 8:53 PM Rahul Shirsat <
rahul(dot)shirsat(at)enterprisedb(dot)com> wrote:

> Fixed the above observation. Removed unnecessary code for calling
> slickgrid delete API.
>
> On Tue, Jan 19, 2021 at 3:30 PM Nikhil Mohite <
> nikhil(dot)mohite(at)enterprisedb(dot)com> wrote:
>
>> Hi Rahul,
>>
>> While reviewing the patch, found one observation with deleted records.
>> 1. Selected multiple records and click on delete records.
>> [image: Screenshot 2021-01-19 at 3.05.55 PM.png]
>> 2. Now unselect or unmark any record. (click on index column cell to
>> unselect the row)
>> [image: Screenshot 2021-01-19 at 3.06.04 PM.png]
>> 3. Click on the Save data changes button.
>> 4. All selected records get deleted but the unselected records remain in
>> the grid.
>> [image: Screenshot 2021-01-19 at 3.06.13 PM.png]
>> 5. After re-executing the filter query that record gets removed from the
>> grid.
>>
>> Regards,
>> Nikhil Mohite.
>>
>>
>>
>> On Tue, Jan 19, 2021 at 1:41 PM Akshay Joshi <
>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Nikhil
>>>
>>> Can you please review it.
>>>
>>> On Mon, Jan 18, 2021 at 8:21 PM Rahul Shirsat <
>>> rahul(dot)shirsat(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi Hackers,
>>>>
>>>> Please find the attached patch which resolves the issue of deleting
>>>> records when the user tries to delete multiple records step by step.
>>>>
>>>> --
>>>> *Rahul Shirsat*
>>>> Senior Software Engineer | EnterpriseDB Corporation.
>>>>
>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>> *pgAdmin Hacker | Principal Software Architect*
>>> *EDB Postgres <http://edbpostgres.com>*
>>>
>>> *Mobile: +91 976-788-8246*
>>>
>>
>
> --
> *Rahul Shirsat*
> Senior Software Engineer | EnterpriseDB Corporation.
>

--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Khushboo Vashi 2021-01-20 07:24:56 [pgAdmin4][Patch] - Fixed various issues of the Macros
Previous Message Akshay Joshi 2021-01-20 07:09:29 pgAdmin 4 commit: Fixed an issue of deleting records when the user trie