From: | Rahul Shirsat <rahul(dot)shirsat(at)enterprisedb(dot)com> |
---|---|
To: | Nikhil Mohite <nikhil(dot)mohite(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
Subject: | Re: [pgAdmin] RM6098 Manually deleting from table view hangs |
Date: | 2021-01-19 15:22:55 |
Message-ID: | CAKtn9dOBt2js4TTdb7MiwEVv4WcU0AprZtQLbpOFq_GVvtPh8A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Fixed the above observation. Removed unnecessary code for calling slickgrid
delete API.
On Tue, Jan 19, 2021 at 3:30 PM Nikhil Mohite <
nikhil(dot)mohite(at)enterprisedb(dot)com> wrote:
> Hi Rahul,
>
> While reviewing the patch, found one observation with deleted records.
> 1. Selected multiple records and click on delete records.
> [image: Screenshot 2021-01-19 at 3.05.55 PM.png]
> 2. Now unselect or unmark any record. (click on index column cell to
> unselect the row)
> [image: Screenshot 2021-01-19 at 3.06.04 PM.png]
> 3. Click on the Save data changes button.
> 4. All selected records get deleted but the unselected records remain in
> the grid.
> [image: Screenshot 2021-01-19 at 3.06.13 PM.png]
> 5. After re-executing the filter query that record gets removed from the
> grid.
>
> Regards,
> Nikhil Mohite.
>
>
>
> On Tue, Jan 19, 2021 at 1:41 PM Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Hi Nikhil
>>
>> Can you please review it.
>>
>> On Mon, Jan 18, 2021 at 8:21 PM Rahul Shirsat <
>> rahul(dot)shirsat(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Please find the attached patch which resolves the issue of deleting
>>> records when the user tries to delete multiple records step by step.
>>>
>>> --
>>> *Rahul Shirsat*
>>> Senior Software Engineer | EnterpriseDB Corporation.
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Principal Software Architect*
>> *EDB Postgres <http://edbpostgres.com>*
>>
>> *Mobile: +91 976-788-8246*
>>
>
--
*Rahul Shirsat*
Senior Software Engineer | EnterpriseDB Corporation.
Attachment | Content-Type | Size |
---|---|---|
RM6098_v2.patch | application/octet-stream | 703 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Akshay Joshi | 2021-01-20 07:09:29 | pgAdmin 4 commit: Fixed an issue of deleting records when the user trie |
Previous Message | Akshay Joshi | 2021-01-19 10:53:03 | pgAdmin 4 commit: 1) Handle the version conflict exception in dependenc |