| From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
|---|---|
| To: | Yosry Muhammad <yosrym93(at)gmail(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: Query Tool JS Minimal Refactoring |
| Date: | 2019-08-19 05:57:04 |
| Message-ID: | CANxoLDeJVCEn5Kt-9ZURbFSsac2OppgGBrNDiH9KmNxvkdakYA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi Yosry
Jasmine tests are failing, can you please fix those and resend the patch.
On Fri, Aug 16, 2019 at 11:23 PM Yosry Muhammad <yosrym93(at)gmail(dot)com> wrote:
> Hi hackers,
>
> Please find attached a patch with minimal refactoring of:
> web/pgadmin/tools/sqleditor/static/js/sqleditor.js
>
> This includes merging 2 redundant functions into one and renaming some
> functions to have more expressive and consistent names.
>
> Please review !
> Thanks.
> --
> *Yosry Muhammad Yosry*
>
> Computer Engineering student,
> The Faculty of Engineering,
> Cairo University (2021).
> Class representative of CMP 2021.
> https://www.linkedin.com/in/yosrym93/
>
--
*Thanks & Regards*
*Akshay Joshi*
*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Akshay Joshi | 2019-08-19 06:17:52 | pgAdmin 4 commit: 1) Added new python test that checks the transaction |
| Previous Message | Khushboo Vashi | 2019-08-19 04:54:12 | Re: Minor Readme changes |