| From: | Yosry Muhammad <yosrym93(at)gmail(dot)com> |
|---|---|
| To: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Query Tool JS Minimal Refactoring |
| Date: | 2019-08-16 17:53:10 |
| Message-ID: | CAFSMqn8DnxHf7LPLmQOX+8Z6Tivbe59f9MqtYKU2W_JE3T61SA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi hackers,
Please find attached a patch with minimal refactoring of:
web/pgadmin/tools/sqleditor/static/js/sqleditor.js
This includes merging 2 redundant functions into one and renaming some
functions to have more expressive and consistent names.
Please review !
Thanks.
--
*Yosry Muhammad Yosry*
Computer Engineering student,
The Faculty of Engineering,
Cairo University (2021).
Class representative of CMP 2021.
https://www.linkedin.com/in/yosrym93/
| Attachment | Content-Type | Size |
|---|---|---|
| sqleditorjs_refactor.patch | text/x-patch | 8.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Akshay Joshi | 2019-08-17 10:29:07 | pgAdmin 4 commit: Ensure compound triggers for event should be updated |
| Previous Message | Akshay Joshi | 2019-08-16 12:29:32 | Release next week |