From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
---|---|
To: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin][patch] Theme component usage fix |
Date: | 2022-06-30 09:49:48 |
Message-ID: | CANxoLDeFT_yGZPLy21qkptT+Ncb9pnSE3hZUg_=Em8khB=MFVQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Thanks, the patch applied.
On Thu, Jun 30, 2022 at 3:03 PM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
> Hi,
>
> Attached is the updated patch.
>
> On Thu, Jun 30, 2022 at 2:26 PM Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Hi Aditya
>>
>> Please fix the linter error and send the patch again.
>>
>> On Thu, Jun 30, 2022 at 2:12 PM Aditya Toshniwal <
>> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>>
>>> Hi,
>>>
>>> Attached is the rebased patch.
>>>
>>> On Thu, Jun 30, 2022 at 2:06 PM Akshay Joshi <
>>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi Aditya
>>>>
>>>> Can you please rebase and send the patch again.
>>>>
>>>> On Thu, Jun 30, 2022 at 1:56 PM Aditya Toshniwal <
>>>> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>>>>
>>>>> Hi Hackers,
>>>>>
>>>>> Attached patch fixes the usage of the Theme component.
>>>>> Please note, a component should not be wrapped in multiple Theme
>>>>> components as it will create styling issues.
>>>>>
>>>>> --
>>>>> Thanks,
>>>>> Aditya Toshniwal
>>>>> pgAdmin Hacker | Software Architect | *edbpostgres.com*
>>>>> <http://edbpostgres.com>
>>>>> "Don't Complain about Heat, Plant a TREE"
>>>>>
>>>>
>>>>
>>>> --
>>>>
>>>> <http://www.enterprisedb.com>
>>>>
>>>> Akshay Joshi
>>>>
>>>> Principal Software Architect
>>>>
>>>> +91 9767888246
>>>>
>>>> www.enterprisedb.com
>>>>
>>>> <https://www.linkedin.com/company/edbpostgres>
>>>> <https://twitter.com/edbpostgres?lang=en>
>>>> <https://www.facebook.com/EDBpostgres>
>>>> <https://www.instagram.com/EDBpostgres/>
>>>>
>>>
>>>
>>> --
>>> Thanks,
>>> Aditya Toshniwal
>>> pgAdmin Hacker | Software Architect | *edbpostgres.com*
>>> <http://edbpostgres.com>
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>>
>> --
>>
>> <http://www.enterprisedb.com>
>>
>> Akshay Joshi
>>
>> Principal Software Architect
>>
>> +91 9767888246
>>
>> www.enterprisedb.com
>>
>> <https://www.linkedin.com/company/edbpostgres>
>> <https://twitter.com/edbpostgres?lang=en>
>> <https://www.facebook.com/EDBpostgres>
>> <https://www.instagram.com/EDBpostgres/>
>>
>
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin Hacker | Software Architect | *edbpostgres.com*
> <http://edbpostgres.com>
> "Don't Complain about Heat, Plant a TREE"
>
--
Akshay Joshi
Principal Software Architect
+91 9767888246
<https://www.linkedin.com/company/edbpostgres>
<https://twitter.com/edbpostgres?lang=en>
<https://www.facebook.com/EDBpostgres>
<https://www.instagram.com/EDBpostgres/>
From | Date | Subject | |
---|---|---|---|
Next Message | fred.escallier | 2022-06-30 12:37:42 | Re: Translators: Release next week |
Previous Message | Akshay Joshi | 2022-06-30 09:48:56 | pgAdmin 4 commit: Theme component usage has been fixed, a component sho |