| From: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com> |
|---|---|
| To: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin][patch] Theme component usage fix |
| Date: | 2022-06-30 09:33:13 |
| Message-ID: | CAM9w-_kgHGQV4oZACpWKn5mD+hcxSMpnzykVuY0f43onFZCx5Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi,
Attached is the updated patch.
On Thu, Jun 30, 2022 at 2:26 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:
> Hi Aditya
>
> Please fix the linter error and send the patch again.
>
> On Thu, Jun 30, 2022 at 2:12 PM Aditya Toshniwal <
> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> Attached is the rebased patch.
>>
>> On Thu, Jun 30, 2022 at 2:06 PM Akshay Joshi <
>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Aditya
>>>
>>> Can you please rebase and send the patch again.
>>>
>>> On Thu, Jun 30, 2022 at 1:56 PM Aditya Toshniwal <
>>> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi Hackers,
>>>>
>>>> Attached patch fixes the usage of the Theme component.
>>>> Please note, a component should not be wrapped in multiple Theme
>>>> components as it will create styling issues.
>>>>
>>>> --
>>>> Thanks,
>>>> Aditya Toshniwal
>>>> pgAdmin Hacker | Software Architect | *edbpostgres.com*
>>>> <http://edbpostgres.com>
>>>> "Don't Complain about Heat, Plant a TREE"
>>>>
>>>
>>>
>>> --
>>>
>>> <http://www.enterprisedb.com>
>>>
>>> Akshay Joshi
>>>
>>> Principal Software Architect
>>>
>>> +91 9767888246
>>>
>>> www.enterprisedb.com
>>>
>>> <https://www.linkedin.com/company/edbpostgres>
>>> <https://twitter.com/edbpostgres?lang=en>
>>> <https://www.facebook.com/EDBpostgres>
>>> <https://www.instagram.com/EDBpostgres/>
>>>
>>
>>
>> --
>> Thanks,
>> Aditya Toshniwal
>> pgAdmin Hacker | Software Architect | *edbpostgres.com*
>> <http://edbpostgres.com>
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
>
> <http://www.enterprisedb.com>
>
> Akshay Joshi
>
> Principal Software Architect
>
> +91 9767888246
>
> www.enterprisedb.com
>
> <https://www.linkedin.com/company/edbpostgres>
> <https://twitter.com/edbpostgres?lang=en>
> <https://www.facebook.com/EDBpostgres>
> <https://www.instagram.com/EDBpostgres/>
>
--
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Software Architect | *edbpostgres.com*
<http://edbpostgres.com>
"Don't Complain about Heat, Plant a TREE"
| Attachment | Content-Type | Size |
|---|---|---|
| theme_comp_usage_v3.patch | application/octet-stream | 13.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Akshay Joshi | 2022-06-30 09:43:45 | pgAdmin 4 v6.11 Released |
| Previous Message | Akshay Joshi | 2022-06-30 08:56:28 | Re: [pgAdmin][patch] Theme component usage fix |