| From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
|---|---|
| To: | Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin4][Patch] - RM 4555 - RE-SQL for Exclusion Constraint |
| Date: | 2019-08-05 07:50:47 |
| Message-ID: | CANxoLDeEAM+XX+bW5NOdcoyyv583NQbfUc-3kynyzpeOnGOXOQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi Khushboo
Test case are working fine, some minor review comments:
- Scenario name "Create/Alter Exclusion Constraint" repeating twice
instead of that it should be more understandable.
- File name should not be like "create/alter_exclusion_constraint_1.sql"
it should be like 'alter_comment.sql'.
On Mon, Aug 5, 2019 at 12:30 PM Khushboo Vashi <
khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
> Hi,
>
> Please find the attached patch for the RE-SQL tests of the Exclusion
> constraint node with some bug fixes in SQL.
>
> Thanks,
> Khushboo
>
--
*Thanks & Regards*
*Akshay Joshi*
*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2019-08-05 07:57:37 | pgAdmin 4 commit: Update Chinese translation. |
| Previous Message | Akshay Joshi | 2019-08-05 07:20:45 | Re: [pgAdmin][RM4559] Updating a trigger on EPAS server throws browser error |