From: | Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com> |
---|---|
To: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin4][Patch] - RM 4555 - RE-SQL for Exclusion Constraint |
Date: | 2019-08-05 08:30:28 |
Message-ID: | CAFOhELebuQXDKz850J0QVF8wywLXG1EShktTkU19wfgxWbYYLQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Akshay,
Please find the attached updated patch.
On Mon, Aug 5, 2019 at 1:20 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:
> Hi Khushboo
>
> Test case are working fine, some minor review comments:
>
> - Scenario name "Create/Alter Exclusion Constraint" repeating twice
> instead of that it should be more understandable.
> - File name should not be like
> "create/alter_exclusion_constraint_1.sql" it should be like
> 'alter_comment.sql'.
>
>
> Fixed.
Thanks,
Khushboo
> On Mon, Aug 5, 2019 at 12:30 PM Khushboo Vashi <
> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> Please find the attached patch for the RE-SQL tests of the Exclusion
>> constraint node with some bug fixes in SQL.
>>
>> Thanks,
>> Khushboo
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>
Attachment | Content-Type | Size |
---|---|---|
RM_4555_v1.patch | application/octet-stream | 22.5 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Akshay Joshi | 2019-08-05 10:56:13 | pgAdmin 4 commit: Add Reverse Engineered SQL tests for Exclusion Constr |
Previous Message | Dave Page | 2019-08-05 07:57:37 | pgAdmin 4 commit: Update Chinese translation. |