| From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
|---|---|
| To: | Rahul Shirsat <rahul(dot)shirsat(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin][RM4696] Add RE-SQL/MSQL test cases for Materialized View |
| Date: | 2019-11-21 07:38:44 |
| Message-ID: | CANxoLDeCm9b2u=G5+eJU6NJQDpa0AJGFzmRw6iTfVf6ZAHBXMQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi Rahul
Some more review comments:
- Don't create new file test_view.json as I tested and committed the old
code.
- Remove hardcoded "oid: 17869" from JSON file.
- MSQL endpoints and file name missing in some test cases.
- Cover all the controls in create and alter as much as possible.
On Tue, Nov 19, 2019 at 6:27 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:
> Hi Rahul
>
> Test cases failing on all EPAS servers. Please fix and send the patch
> again.
>
> On Tue, Nov 19, 2019 at 12:47 PM Rahul Shirsat <
> rahul(dot)shirsat(at)enterprisedb(dot)com> wrote:
>
>> Hi Hackers,
>>
>> I have attached the patch for RE-SQL/MSQL test cases for View as well as
>> Materialized View.
>>
>> --
>> *Rahul Shirsat*
>> Software Engineer | EnterpriseDB Corporation.
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>
--
*Thanks & Regards*
*Akshay Joshi*
*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Shubham Agarwal | 2019-11-21 10:09:42 | Re: Fixes for pgAdmin feature tests |
| Previous Message | Aditya Toshniwal | 2019-11-21 06:28:02 | Re: [pgAdmin][RM4818] Unable to handle loss of connection to server |