Re: [pgAdmin][RM4696] Add RE-SQL/MSQL test cases for Materialized View

From: Rahul Shirsat <rahul(dot)shirsat(at)enterprisedb(dot)com>
To: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin][RM4696] Add RE-SQL/MSQL test cases for Materialized View
Date: 2019-11-22 19:07:15
Message-ID: CAKtn9dNz1ozbJWzJw_qVLx3QAxcNSjCCJWqB8HW3Qn5Hooz-pA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Akshay,

Please find the correction done in this updated patch based on your review
comments.

Regards,
Rahul Shirsat.

On Thu, Nov 21, 2019 at 1:08 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:

> Hi Rahul
>
> Some more review comments:
>
> - Don't create new file test_view.json as I tested and committed the
> old code.
> - Remove hardcoded "oid: 17869" from JSON file.
> - MSQL endpoints and file name missing in some test cases.
> - Cover all the controls in create and alter as much as possible.
>
>
> On Tue, Nov 19, 2019 at 6:27 PM Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Hi Rahul
>>
>> Test cases failing on all EPAS servers. Please fix and send the patch
>> again.
>>
>> On Tue, Nov 19, 2019 at 12:47 PM Rahul Shirsat <
>> rahul(dot)shirsat(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Hackers,
>>>
>>> I have attached the patch for RE-SQL/MSQL test cases for View as well as
>>> Materialized View.
>>>
>>> --
>>> *Rahul Shirsat*
>>> Software Engineer | EnterpriseDB Corporation.
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>

--
*Rahul Shirsat*
Software Engineer | EnterpriseDB Corporation.

Attachment Content-Type Size
RM4696_v2.patch application/octet-stream 112.6 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2019-11-25 05:15:18 pgAdmin 4 commit: Updated the json file name from 'servers.json' to 'pg
Previous Message Abhilasha Narendra 2019-11-22 09:20:42 [pgAdmin][RM4836] Wrong default value in Container Deployment section of documentation