From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
---|---|
To: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin][SonarQube] Function returns same value |
Date: | 2020-07-30 08:36:36 |
Message-ID: | CANxoLDeACP55McdfdJZYQ-FxbVqGuVMSqtDaRYeBPstjjzWq7A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Thanks, patch applied.
On Thu, Jul 30, 2020 at 1:09 PM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
> Hi Hackers,
>
> Attached is the patch to:
> - Refactor functions to not always return the same value
> - Rename "cls" to "self" or add the missing "self" parameter.
> - Remove useless assignment to variables
> And a minor UI foreign key dialog add columns.
>
> Please review.
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
> <http://edbpostgres.com>
> "Don't Complain about Heat, Plant a TREE"
>
--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres <http://edbpostgres.com>*
*Mobile: +91 976-788-8246*
From | Date | Subject | |
---|---|---|---|
Next Message | Aditya Toshniwal | 2020-07-30 08:52:34 | Re: WIP: SQL Formatter |
Previous Message | Akshay Joshi | 2020-07-30 08:36:03 | pgAdmin 4 commit: Fixed following SonarQube issues: |