[pgAdmin][SonarQube] Function returns same value

From: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: [pgAdmin][SonarQube] Function returns same value
Date: 2020-07-30 07:39:05
Message-ID: CAM9w-_nYVzkPUBmWe1KapC6z3gsHG=ZWuoxVvOHd=2dM+9Z8gg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Hackers,

Attached is the patch to:
- Refactor functions to not always return the same value
- Rename "cls" to "self" or add the missing "self" parameter.
- Remove useless assignment to variables
And a minor UI foreign key dialog add columns.

Please review.

--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
<http://edbpostgres.com>
"Don't Complain about Heat, Plant a TREE"

Attachment Content-Type Size
sonarqube.samevalue.patch application/octet-stream 62.8 KB

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2020-07-30 08:24:09 Re: WIP: SQL Formatter
Previous Message Akshay Joshi 2020-07-30 06:44:58 Re: Sonarqube fixes - test_utils.py