Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
Cc: Dave Page <dpage(at)pgadmin(dot)org>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
Subject: Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme
Date: 2019-11-13 06:06:16
Message-ID: CANxoLDe2JeR6DNnm+7b9TsbQ113AR1AbBb2Ab-cQV_zyDTaxTA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, patch applied.

On Wed, Nov 13, 2019 at 10:46 AM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:

> Hi Hackers,
>
> Attached is the patch to set browser autofill color. I've used primary
> light color to highlight autofill. Note that, this works only on webkit
> browsers.
> Kindly review.
>
> On Wed, Nov 13, 2019 at 10:03 AM Aditya Toshniwal <
> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>
>> Hi Dave,
>>
>> On Tue, Nov 12, 2019 at 7:29 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>>>
>>>
>>> On Tue, Nov 12, 2019 at 1:47 PM Aditya Toshniwal <
>>> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi Hackers,
>>>>
>>>> Attached is the patch to customize the scrollbar styling. A new SASS
>>>> variable added - $scrollbar-base-color is added to change the color as per
>>>> theme.
>>>> Please note, customization of scrollbar works only in webkit browsers
>>>> like Chrome, Safari. Mozilla does not have any way to customize.
>>>>
>>>
>>> That looks much nicer :-).
>>>
>>> One more issue I just spotted - I'm guessing it's specific to Alertify
>>> dialogues:
>>>
>>> [image: Screenshot 2019-11-12 at 13.57.34.png]
>>>
>> This is your browser autofill which is changing the color and not the
>> issue with the dialogs.
>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Sr. Software Engineer | EnterpriseDB India | Pune
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>

--
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Nagesh Dhope 2019-11-13 11:30:28 [pgAdmin][RM4930] [Accessibility] Main window tan navigation
Previous Message Akshay Joshi 2019-11-13 06:05:17 pgAdmin 4 commit: Set browser autofill color as primary light to highli