Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme

From: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
Subject: Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme
Date: 2019-11-13 05:15:36
Message-ID: CAM9w-_=Jy6kpDyg-FGGz961-djDMKe6hKFa51A5jAbhoygKYVg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Hackers,

Attached is the patch to set browser autofill color. I've used primary
light color to highlight autofill. Note that, this works only on webkit
browsers.
Kindly review.

On Wed, Nov 13, 2019 at 10:03 AM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:

> Hi Dave,
>
> On Tue, Nov 12, 2019 at 7:29 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>>
>>
>> On Tue, Nov 12, 2019 at 1:47 PM Aditya Toshniwal <
>> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached is the patch to customize the scrollbar styling. A new SASS
>>> variable added - $scrollbar-base-color is added to change the color as per
>>> theme.
>>> Please note, customization of scrollbar works only in webkit browsers
>>> like Chrome, Safari. Mozilla does not have any way to customize.
>>>
>>
>> That looks much nicer :-).
>>
>> One more issue I just spotted - I'm guessing it's specific to Alertify
>> dialogues:
>>
>> [image: Screenshot 2019-11-12 at 13.57.34.png]
>>
> This is your browser autofill which is changing the color and not the
> issue with the dialogs.
>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>

--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"

Attachment Content-Type Size
RM4348.part5_autofill.patch application/octet-stream 1022 bytes

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2019-11-13 05:49:29 pgAdmin 4 commit: Fixed feature tests related to process watcher.
Previous Message Aditya Toshniwal 2019-11-13 04:33:40 Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme