| From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
|---|---|
| To: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin][RM5815] Generate script is not working in new window |
| Date: | 2020-09-09 14:43:13 |
| Message-ID: | CANxoLDdwhpo4J+m3-CaavhvaDi2rg9G-QPUk6ivQPeA-XTMN+Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Thanks, patch applied.
On Wed, Sep 9, 2020 at 3:19 PM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
> Hi Hackers,
>
> If schema diff is opened in a new tab and "Generate script" is clicked
> (with query tool setting "open in new tab" set to true) then it shows a
> forever spinner because of pop up blocks.
>
> Attached patch will show an alert message in that case so that the user
> can allow pop up and generate the script again.
>
> Please review.
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
> <http://edbpostgres.com>
> "Don't Complain about Heat, Plant a TREE"
>
--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres <http://edbpostgres.com>*
*Mobile: +91 976-788-8246*
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Akshay Joshi | 2020-09-09 14:43:23 | Re: [pgAdmin][Patch] #4059 Query Tool button in Query Tool to open a new Query Window |
| Previous Message | Akshay Joshi | 2020-09-09 14:41:05 | pgAdmin 4 commit: Fixed an issue where clicking on the 'Generate script |