[pgAdmin][RM5815] Generate script is not working in new window

From: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: [pgAdmin][RM5815] Generate script is not working in new window
Date: 2020-09-09 09:48:27
Message-ID: CAM9w-_knay-688=uCiM7C=C+79H2-t9kBgFnVekohm75878JOg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Hackers,

If schema diff is opened in a new tab and "Generate script" is clicked
(with query tool setting "open in new tab" set to true) then it shows a
forever spinner because of pop up blocks.

Attached patch will show an alert message in that case so that the user can
allow pop up and generate the script again.

Please review.

--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
<http://edbpostgres.com>
"Don't Complain about Heat, Plant a TREE"

Attachment Content-Type Size
RM5815.patch application/octet-stream 3.3 KB

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2020-09-09 10:05:03 pgAdmin 4 commit: Fixed an issue where vacuum options not consider in S
Previous Message Akshay Joshi 2020-09-09 09:04:27 pgAdmin 4 commit: Fixed an issue while refreshing Resource Group. Fixes