Re: [Patch][pgAdmin] RM4203 Rename Database by another user

Hi Rahul

Following are the review comments:

- Why you have changed the order of the toolbar button on the browser
tree? It should not.
- *sqleditor.js (check_db_name_change function)*
- var declaration should be comma-separated instead of writing var,
again and again.
- Add proper comments.
- Remove dots from the string "Database moved/renamed.."
- "Please note that the database you are working on has been moved or
renamed to ${data.actual_db_name}. Refresh databases in browser panel or
click OK to continue.." should be changed to "Current database has been
moved or renamed to ${data.actual_db_name}. Click on the OK button to
refresh the database name."

On Wed, May 26, 2021 at 2:07 PM Rahul Shirsat <
rahul(dot)shirsat(at)enterprisedb(dot)com> wrote:

> Hi Hackers,
>
> Please find the attached patch which resolves the issue of renaming the
> database by another user.
>
> A minor issue of navigation button alignment is also fixed in this patch.
>
> --
> *Rahul Shirsat*
> Senior Software Engineer | EnterpriseDB Corporation.
>

--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*