Re: [Patch][pgAdmin] RM4203 Rename Database by another user

Hi Akshay,

On Thu, May 27, 2021 at 12:19 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:

> Hi Rahul
>
> Following are the review comments:
>
> - Why you have changed the order of the toolbar button on the browser
> tree? It should not.
>
> Changes were related to the wcDocker issue showing reverse
order buttons, so had to change in the pgAdmin app to reflect it correctly.

>
> - *sqleditor.js (check_db_name_change function)*
> - var declaration should be comma-separated instead of writing var,
> again and again.
>
> Done.

>
> - Add proper comments.
>
> This too is taken care of.

>
> - Remove dots from the string "Database moved/renamed.."
>
> Done.

>
> - "Please note that the database you are working on has been moved or
> renamed to ${data.actual_db_name}. Refresh databases in browser panel or
> click OK to continue.." should be changed to "Current database has been
> moved or renamed to ${data.actual_db_name}. Click on the OK button to
> refresh the database name."
>
> Done.
Also have done some code refactoring.

>
>
> On Wed, May 26, 2021 at 2:07 PM Rahul Shirsat <
> rahul(dot)shirsat(at)enterprisedb(dot)com> wrote:
>
>> Hi Hackers,
>>
>> Please find the attached patch which resolves the issue of renaming the
>> database by another user.
>>
>> A minor issue of navigation button alignment is also fixed in this patch.
>>
>> --
>> *Rahul Shirsat*
>> Senior Software Engineer | EnterpriseDB Corporation.
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>

--
*Rahul Shirsat*
Senior Software Engineer | EnterpriseDB Corporation.