Quick Links

Re: [pgAdmin4][Patch] - SonarQube Issues - 6 (A conditionally executed single line should be denoted by indentation, A "while" loop should be used instead of a "for" loop, Variables should be declared explicitly)

From:	Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To:	Yogesh Mahajan <yogesh(dot)mahajan(at)enterprisedb(dot)com>
Cc:	pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject:	Re: [pgAdmin4][Patch] - SonarQube Issues - 6 (A conditionally executed single line should be denoted by indentation, A "while" loop should be used instead of a "for" loop, Variables should be declared explicitly)
Date:	2020-06-25 06:58:26
Message-ID:	CANxoLDdkFC-j3wYhqWep=r7Pw25RbSNxX-tXGAYUT0_RUXDagA@mail.gmail.com
Views:	Raw Message \| Whole Thread \| Download mbox \| Resend email
Thread:
Lists:	pgadmin-hackers

Hi Yogesh

Please fix the linter error and send the patch again.

On Thu, Jun 25, 2020 at 12:26 PM Yogesh Mahajan <
yogesh(dot)mahajan(at)enterprisedb(dot)com> wrote:

> Hi,
>
> Please find patch fixing the issues related to below rules -
> 1.A conditionally executed single line should be denoted by indentation,
> 2.A "while" loop should be used instead of a "for" loop, \
> 3.Variables should be declared explicitly)
>
> Thanks,
> Yogesh Mahajan
> QA - Team
> EnterpriseDB Corporation
>
> Phone: +91-9741705709
>

--
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

In response to

[pgAdmin4][Patch] - SonarQube Issues - 6 (A conditionally executed single line should be denoted by indentation, A "while" loop should be used instead of a "for" loop, Variables should be declared explicitly) at 2020-06-25 06:55:15 from Yogesh Mahajan

Responses

Re: [pgAdmin4][Patch] - SonarQube Issues - 6 (A conditionally executed single line should be denoted by indentation, A "while" loop should be used instead of a "for" loop) at 2020-06-25 11:34:43 from Yogesh Mahajan

Browse pgadmin-hackers by date

	From	Date	Subject
Next Message	Akshay Joshi	2020-06-25 06:58:57	pgAdmin 4 commit: Fixed SonarQube issues with the tag unused. All the u
Previous Message	Akshay Joshi	2020-06-25 06:56:02	Re: [pgAdmin4][Patch] - SonarQube Issues - 5 (Rule Boolean checks should not be inverted, Comma operator should not be used)