| From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
|---|---|
| To: | Yogesh Mahajan <yogesh(dot)mahajan(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin4][Patch] - SonarQube Issues - 5 (Rule Boolean checks should not be inverted, Comma operator should not be used) |
| Date: | 2020-06-25 06:56:02 |
| Message-ID: | CANxoLDcN4R9hv-YMUHvtK4Cf0VBJS5Va2aniKpp_xAJ_qGudUw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi Yogesh
Jasmin tests are failing, please fix and resend the patch.
On Thu, Jun 25, 2020 at 11:52 AM Yogesh Mahajan <
yogesh(dot)mahajan(at)enterprisedb(dot)com> wrote:
> Hi,
>
> Please find an updated patch.
>
>
> Thanks,
> Yogesh Mahajan
> QA - Team
> EnterpriseDB Corporation
>
> Phone: +91-9741705709
>
>
> On Wed, Jun 24, 2020 at 12:31 PM Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Hi Yogesh
>>
>> After applying your patch a new sonarqube issue has been found "Change
>> this argument to the documented type: Number." in sqleditor_utils.js
>> Please fix that and resend the patch.
>>
>> On Mon, Jun 22, 2020 at 4:36 PM Yogesh Mahajan <
>> yogesh(dot)mahajan(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Please find patch fixing sonarqube issues related to below rules -
>>>
>>> 1.Boolean checks should not be inverted,
>>> 2.Comma operator should not be used,
>>> 3.Arguments to built-in functions should match documented types,
>>> 4.Redundant pairs of parentheses should be removed,
>>>
>>> Thanks,
>>> Yogesh Mahajan
>>> QA - Team
>>> EnterpriseDB Corporation
>>>
>>> Phone: +91-9741705709
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>
--
*Thanks & Regards*
*Akshay Joshi*
*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*