| From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
|---|---|
| To: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin][RM4421] Inno setup script version compare fix |
| Date: | 2019-07-02 09:04:42 |
| Message-ID: | CANxoLDdjtQK1sqmAhE4JsjdiM_5rvZnF31Po8NeDfGbmWyA8Aw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi Aditya
I have asked Paresh to review the patch, he has given some review comments.
Please fix those and the updated patch asap.
On Tue, Jul 2, 2019 at 1:38 PM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
> Hi Hackers,
>
> Attached is the patch to fix a potential issue where version compare while
> upgrading will be incorrect. Currently, it is comparing strings. So while
> comparing '4.9' and '4.10' it will consider '4.9' as greater.
> The patch will convert the values to float and compare.
>
> Kindly review.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>
--
*Thanks & Regards*
*Akshay Joshi*
*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2019-07-02 09:20:00 | Re: RE-SQL tests for Roles & Resource Group nodes |
| Previous Message | Aditya Toshniwal | 2019-07-02 08:07:28 | [pgAdmin][RM4421] Inno setup script version compare fix |