[pgAdmin][RM4421] Inno setup script version compare fix

From: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: [pgAdmin][RM4421] Inno setup script version compare fix
Date: 2019-07-02 08:07:28
Message-ID: CAM9w-_mnD3MQBMLZdY9oKwSsu6fiwWUFY9ZZob6fPUfiormy1A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Hackers,

Attached is the patch to fix a potential issue where version compare while
upgrading will be incorrect. Currently, it is comparing strings. So while
comparing '4.9' and '4.10' it will consider '4.9' as greater.
The patch will convert the values to float and compare.

Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"

Attachment Content-Type Size
win.ver_compare.patch application/octet-stream 663 bytes

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2019-07-02 09:04:42 Re: [pgAdmin][RM4421] Inno setup script version compare fix
Previous Message Aditya Toshniwal 2019-07-02 07:37:25 Re: [pgAdmin][RM4335] Add EXPLAIN option SETTINGS and SUMMARY