| From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
|---|---|
| To: | Dave Page <dpage(at)pgadmin(dot)org> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: Fixed some compiler warnings |
| Date: | 2014-01-31 06:03:12 |
| Message-ID: | CANxoLDddyUM=4MH6oMyKn7b6__Bk-cMq8kfZo79jrqj3Q4jX9w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
On Thu, Jan 30, 2014 at 7:35 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> Hi
>
>
> On Thu, Jan 30, 2014 at 9:35 AM, Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Hi Dave
>>
>> I have fixed some compiler warnings which we are facing on OSXMavericks. Attached
>> is the patch file. Can you please review it.
>>
>> If patch looks good to you then can you please commit it.
>>
>>
> It mostly looks good, but what's with the operator changes? Why is it
> complaining about x >= 0 ?
>
In all such cases x is unsigned int and compiler complaining about
condition "x >=0" will always true.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
--
*Akshay Joshi*
*Principal Software Engineer *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2014-01-31 13:56:45 | Re: Fixed some compiler warnings |
| Previous Message | David E. Wheeler | 2014-01-30 17:34:03 | Re: Add CREATE EXTENSION Support |