Re: Fixed some compiler warnings

On Fri, Jan 31, 2014 at 6:03 AM, Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com
> wrote:

>
>
>
> On Thu, Jan 30, 2014 at 7:35 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Hi
>>
>>
>> On Thu, Jan 30, 2014 at 9:35 AM, Akshay Joshi <
>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Dave
>>>
>>> I have fixed some compiler warnings which we are facing on OSXMavericks. Attached
>>> is the patch file. Can you please review it.
>>>
>>> If patch looks good to you then can you please commit it.
>>>
>>>
>> It mostly looks good, but what's with the operator changes? Why is it
>> complaining about x >= 0 ?
>>
>
> In all such cases x is unsigned int and compiler complaining about
> condition "x >=0" will always true.
>

Ahh yes. However, the proposed fix will always evaluate to true won't it?

if (i > 0 || i == 0)
{

}

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company