Re: [RM3645] Start and End Date does not delete for Schedules in pgAgent Job

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
Cc: Rahul Shirsat <rahul(dot)shirsat(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [RM3645] Start and End Date does not delete for Schedules in pgAgent Job
Date: 2020-04-01 09:50:23
Message-ID: CANxoLDdZo5oJFs_vUcGUsO+sd1jMNFS5J8FzLhbODqX3UoED_A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, patch applied.

On Tue, Mar 31, 2020 at 2:21 PM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:

> Hi Rahul,
>
> The patch looks good to me. It can be committed.
>
> On Tue, Mar 31, 2020 at 2:15 PM Rahul Shirsat <
> rahul(dot)shirsat(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> Ignore the previous mail, find the latest patch attached.
>>
>> On Tue, Mar 31, 2020 at 2:14 PM Rahul Shirsat <
>> rahul(dot)shirsat(at)enterprisedb(dot)com> wrote:
>>
>>> Thanks Aditya for reviewing.
>>>
>>> I have made the relevant changes, please find the inclusive patch
>>> attached here.
>>>
>>> --
>>> *Rahul Shirsat*
>>> Software Engineer | EnterpriseDB Corporation.
>>>
>>> On Tue, Mar 31, 2020 at 11:48 AM Aditya Toshniwal <
>>> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi Rahul,
>>>>
>>>> The patch looks good to me. But can you please remove the placeholder
>>>> in the properties tab. It looks like some value is set, but I kept it
>>>> empty. Refer below screenshot:
>>>>
>>>> [image: image.png]
>>>>
>>>> On Tue, Mar 31, 2020 at 11:24 AM Akshay Joshi <
>>>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>>>
>>>>> Hi Aditya
>>>>>
>>>>> Can you please review it.
>>>>>
>>>>> On Mon, Mar 30, 2020 at 5:57 PM Rahul Shirsat <
>>>>> rahul(dot)shirsat(at)enterprisedb(dot)com> wrote:
>>>>>
>>>>>> Hi Hackers,
>>>>>>
>>>>>> Please find the patch for pgagents schedules dates issue.
>>>>>>
>>>>>> --
>>>>>> *Rahul Shirsat*
>>>>>> Software Engineer | EnterpriseDB Corporation.
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> *Thanks & Regards*
>>>>> *Akshay Joshi*
>>>>>
>>>>> *Sr. Software Architect*
>>>>> *EnterpriseDB Software India Private Limited*
>>>>> *Mobile: +91 976-788-8246*
>>>>>
>>>>
>>>>
>>>> --
>>>> Thanks and Regards,
>>>> Aditya Toshniwal
>>>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
>>>> "Don't Complain about Heat, Plant a TREE"
>>>>
>>>
>>>
>>> --
>>> *Rahul Shirsat*
>>> Software Engineer | EnterpriseDB Corporation.
>>>
>>
>>
>> --
>> *Rahul Shirsat*
>> Software Engineer | EnterpriseDB Corporation.
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>

--
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2020-04-01 09:50:40 Re: [pgAdmin][RM5268] Wrong SQL generated when we update FTS Configuration and FTS Dictionary
Previous Message Akshay Joshi 2020-04-01 09:48:23 pgAdmin 4 commit: Ensure that the start and end date should be deleted