Re: [RM3645] Start and End Date does not delete for Schedules in pgAgent Job

From: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
To: Rahul Shirsat <rahul(dot)shirsat(at)enterprisedb(dot)com>
Cc: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [RM3645] Start and End Date does not delete for Schedules in pgAgent Job
Date: 2020-03-31 08:51:18
Message-ID: CAM9w-_mr1qHaZu96e7847_CcQpe+yZ3D5991=sNpqHWBZYHbPg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Rahul,

The patch looks good to me. It can be committed.

On Tue, Mar 31, 2020 at 2:15 PM Rahul Shirsat <
rahul(dot)shirsat(at)enterprisedb(dot)com> wrote:

> Hi,
>
> Ignore the previous mail, find the latest patch attached.
>
> On Tue, Mar 31, 2020 at 2:14 PM Rahul Shirsat <
> rahul(dot)shirsat(at)enterprisedb(dot)com> wrote:
>
>> Thanks Aditya for reviewing.
>>
>> I have made the relevant changes, please find the inclusive patch
>> attached here.
>>
>> --
>> *Rahul Shirsat*
>> Software Engineer | EnterpriseDB Corporation.
>>
>> On Tue, Mar 31, 2020 at 11:48 AM Aditya Toshniwal <
>> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Rahul,
>>>
>>> The patch looks good to me. But can you please remove the placeholder in
>>> the properties tab. It looks like some value is set, but I kept it empty.
>>> Refer below screenshot:
>>>
>>> [image: image.png]
>>>
>>> On Tue, Mar 31, 2020 at 11:24 AM Akshay Joshi <
>>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi Aditya
>>>>
>>>> Can you please review it.
>>>>
>>>> On Mon, Mar 30, 2020 at 5:57 PM Rahul Shirsat <
>>>> rahul(dot)shirsat(at)enterprisedb(dot)com> wrote:
>>>>
>>>>> Hi Hackers,
>>>>>
>>>>> Please find the patch for pgagents schedules dates issue.
>>>>>
>>>>> --
>>>>> *Rahul Shirsat*
>>>>> Software Engineer | EnterpriseDB Corporation.
>>>>>
>>>>
>>>>
>>>> --
>>>> *Thanks & Regards*
>>>> *Akshay Joshi*
>>>>
>>>> *Sr. Software Architect*
>>>> *EnterpriseDB Software India Private Limited*
>>>> *Mobile: +91 976-788-8246*
>>>>
>>>
>>>
>>> --
>>> Thanks and Regards,
>>> Aditya Toshniwal
>>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>>
>> --
>> *Rahul Shirsat*
>> Software Engineer | EnterpriseDB Corporation.
>>
>
>
> --
> *Rahul Shirsat*
> Software Engineer | EnterpriseDB Corporation.
>

--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2020-03-31 15:07:48 pgAdmin 4 commit: Install expect.
Previous Message Rahul Shirsat 2020-03-31 08:45:47 Re: [RM3645] Start and End Date does not delete for Schedules in pgAgent Job