From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
---|---|
To: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin][RM4988] Refactoring of all the SQL files used by pgAdmin4 |
Date: | 2019-12-16 13:24:36 |
Message-ID: | CANxoLDdJXME7ZdSoD5ewZWpG8csOfPjuc3mh_W8UqY=-_V2z_Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Thanks, patch applied.
On Mon, Dec 16, 2019 at 5:40 PM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
> Hi Hackers,
>
> Attached patch which is related to RM4988, reduces the number of hits to edit_mode_types.sql
> (an expensive one).
> Currently, this is query is executed for every column one by one when
> table properties dialog is opened. I've added edit_mode_types_bulk.sql,
> which will fetch the edit types for all the distinct column types used in
> the table in a single DB trip and use that data for each column.
> Also, while generating RE-SQL for columns, edit_mode_types.sql will not
> be executed.
> This will definitely reduce time.
>
> Kindly review.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>
--
*Thanks & Regards*
*Akshay Joshi*
*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*
From | Date | Subject | |
---|---|---|---|
Next Message | Akshay Joshi | 2019-12-17 07:45:33 | pgAdmin 4 commit: Fix an issue where servers.json import fails when run |
Previous Message | Akshay Joshi | 2019-12-16 13:20:38 | pgAdmin 4 commit: Improved performance while fetching edit types for ea |