| From: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com> |
|---|---|
| To: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | [pgAdmin][RM4988] Refactoring of all the SQL files used by pgAdmin4 |
| Date: | 2019-12-16 12:09:37 |
| Message-ID: | CAM9w-_mgjt9ju6057rQi87XpaA5CXSnwkYa=pgLf7wvW4nCs-g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi Hackers,
Attached patch which is related to RM4988, reduces the number of hits
to edit_mode_types.sql
(an expensive one).
Currently, this is query is executed for every column one by one when table
properties dialog is opened. I've added edit_mode_types_bulk.sql, which
will fetch the edit types for all the distinct column types used in the
table in a single DB trip and use that data for each column.
Also, while generating RE-SQL for columns, edit_mode_types.sql will not be
executed.
This will definitely reduce time.
Kindly review.
--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
| Attachment | Content-Type | Size |
|---|---|---|
| RM4988.edit_types.patch | application/octet-stream | 5.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Akshay Joshi | 2019-12-16 13:20:38 | pgAdmin 4 commit: Improved performance while fetching edit types for ea |
| Previous Message | Levitt Olivier | 2019-12-16 09:48:14 | RE: [Pgadmin] [Docker] servers.json import fails when running in desktop mode |