| From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
|---|---|
| To: | Fahar Abbas <fahar(dot)abbas(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [4696] Add RE-SQL/MSQL test cases for Materialized View |
| Date: | 2019-09-05 08:37:09 |
| Message-ID: | CANxoLDdGpuCZu1up5=Ue0hTJkVQDVsxWMH3zH8NKBa6k-zMxtg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi Fahar
Below are the review comments:
- Align test_msql.json file properly.
- Give meaningful scenario names like "Alter MView comment, acl etc.."
- Data for create and alter are identical, i am not sure what exactly
you have changed.
- Create/Alter test cases missing for With Data?, Tablespace, Fill
factor, Table, Toast Table, Privileges. (*Cover maximum controls.*)
On Thu, Sep 5, 2019 at 1:39 PM Fahar Abbas <fahar(dot)abbas(at)enterprisedb(dot)com>
wrote:
> Hi Hackers,
>
> Please find attached the patch for RE-SQL for Materialized view.
>
> Please review and apply the patch.
>
> Will send MSQL patch later.
>
> Kind Regards,
> --
> Fahar Abbas
> QMG
> EnterpriseDB Corporation
> Phone Office: +92-51-835-8874
> Phone Direct: +92-51-8466803
> Mobile: +92-333-5409707
> Skype ID: *live:fahar.abbas*
> Website: www.enterprisedb.com
>
--
*Thanks & Regards*
*Akshay Joshi*
*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2019-09-05 09:40:09 | Re: [4696] Add RE-SQL/MSQL test cases for Materialized View |
| Previous Message | Fahar Abbas | 2019-09-05 08:09:05 | [4696] Add RE-SQL/MSQL test cases for Materialized View |