From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
---|---|
To: | Pramod Ahire <pramod(dot)ahire(at)enterprisedb(dot)com> |
Cc: | Dave Page <dpage(at)pgadmin(dot)org>, Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: Code coverage report generation for JS files |
Date: | 2020-08-07 11:55:10 |
Message-ID: | CANxoLDd6v=MgSBnyNC_U2ZX8hVNEFaLaLpJdWLBHOnWENu8cFw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Thanks, patch applied.
On Fri, Aug 7, 2020 at 2:52 PM Pramod Ahire <pramod(dot)ahire(at)enterprisedb(dot)com>
wrote:
> No Dave, the Makefile target was not added.
>
>
>
> Have attached the patch for same, please do let me know if needed anything
> else.
>
>
>
> @Akshay will you be able to review quickly on this ?
>
>
>
> Thank you :)
>
>
>
> *Pramod Ahire*
>
> *Software Engineer*
>
>
>
> [image:
> https://lh4.googleusercontent.com/U1erEuyI_d0xEUA0CrKjwx9aWQ52HNCxc38dMsLP-ZrLgfVNrhsrNobxlmeOdb1kMPtrrxcUwEHZgbGJC4R0qR4r1sBZa_z9R8ihFRaP2Hr_Wnhq6HcIQHe1ZoviDPwUkTdzNcg]
>
>
>
> C: +91-020-66449600/601
>
> D: +91-9028697679
>
> *edbpostgres.com <http://edbpostgres.com>*
>
>
>
>
>
> *From: *Dave Page <dpage(at)pgadmin(dot)org>
> *Date: *Friday, 7 August 2020 at 2:16 PM
> *To: *Pramod Ahire <pramod(dot)ahire(at)enterprisedb(dot)com>
> *Cc: *Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>, Aditya Toshniwal <
> aditya(dot)toshniwal(at)enterprisedb(dot)com>, pgadmin-hackers <
> pgadmin-hackers(at)postgresql(dot)org>
> *Subject: *Re: Code coverage report generation for JS files
>
>
>
> Was a Makefile target added? Maybe "make coverage"...
>
>
>
> On Fri, Aug 7, 2020 at 8:10 AM Pramod Ahire <pramod(dot)ahire(at)enterprisedb(dot)com>
> wrote:
>
> Thank you :)
>
>
>
> *Pramod Ahire*
>
> *Software Engineer*
>
>
>
> [image:
> https://lh4.googleusercontent.com/U1erEuyI_d0xEUA0CrKjwx9aWQ52HNCxc38dMsLP-ZrLgfVNrhsrNobxlmeOdb1kMPtrrxcUwEHZgbGJC4R0qR4r1sBZa_z9R8ihFRaP2Hr_Wnhq6HcIQHe1ZoviDPwUkTdzNcg]
>
>
>
> C: +91-020-66449600/601
>
> D: +91-9028697679
>
> *edbpostgres.com <http://edbpostgres.com>*
>
>
>
>
>
> *From: *Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
> *Date: *Friday, 7 August 2020 at 12:38 PM
> *To: *Pramod Ahire <pramod(dot)ahire(at)enterprisedb(dot)com>
> *Cc: *Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>,
> pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Dave Page <
> dpage(at)pgadmin(dot)org>
> *Subject: *Re: Code coverage report generation for JS files
>
>
>
> Thanks, patch applied.
>
>
>
>
> --
>
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EDB: http://www.enterprisedb.com
>
--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres <http://edbpostgres.com>*
*Mobile: +91 976-788-8246*
From | Date | Subject | |
---|---|---|---|
Next Message | Akshay Joshi | 2020-08-07 11:55:22 | Re: [pgAdmin][RM5713]:Incorrect DROP SQL for Catalog and Foreign Server |
Previous Message | Akshay Joshi | 2020-08-07 11:54:59 | Re: Bug #5670 - Backup dialog error message does not have close button |