From: | Pramod Ahire <pramod(dot)ahire(at)enterprisedb(dot)com> |
---|---|
To: | Dave Page <dpage(at)pgadmin(dot)org> |
Cc: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>, Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: Code coverage report generation for JS files |
Date: | 2020-08-07 09:22:35 |
Message-ID: | 752E2FC7-4677-4A30-8E7E-AC039DC1DD11@enterprisedb.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
No Dave, the Makefile target was not added.
Have attached the patch for same, please do let me know if needed anything else.
@Akshay will you be able to review quickly on this ?
Thank you :)
Pramod Ahire
Software Engineer
C: +91-020-66449600/601
D: +91-9028697679
From: Dave Page <dpage(at)pgadmin(dot)org>
Date: Friday, 7 August 2020 at 2:16 PM
To: Pramod Ahire <pramod(dot)ahire(at)enterprisedb(dot)com>
Cc: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>, Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Code coverage report generation for JS files
Was a Makefile target added? Maybe "make coverage"...
On Fri, Aug 7, 2020 at 8:10 AM Pramod Ahire <pramod(dot)ahire(at)enterprisedb(dot)com> wrote:
Thank you :)
Pramod Ahire
Software Engineer
C: +91-020-66449600/601
D: +91-9028697679
From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
Date: Friday, 7 August 2020 at 12:38 PM
To: Pramod Ahire <pramod(dot)ahire(at)enterprisedb(dot)com>
Cc: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Dave Page <dpage(at)pgadmin(dot)org>
Subject: Re: Code coverage report generation for JS files
Thanks, patch applied.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
Attachment | Content-Type | Size |
---|---|---|
makefile_added_coverage.patch | application/octet-stream | 357 bytes |
![]() |
image/png | 68.4 KB |
![]() |
image/png | 68.4 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Yogesh Mahajan | 2020-08-07 09:43:59 | Bug #5670 - Backup dialog error message does not have close button |
Previous Message | Dave Page | 2020-08-07 09:07:31 | pgAdmin 4 commit: Clarify some of the differences when running in serve |