Re: [pgAdmin4][Patch] - RM 5422 - Synonym Dependencies tab shows incorrect data

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>
Cc: navnath gadakh <navnath(dot)gadakh(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch] - RM 5422 - Synonym Dependencies tab shows incorrect data
Date: 2020-05-04 07:54:30
Message-ID: CANxoLDd1Dv3cAVT5RX_WByWcyQdYLHncbD98uXRoAKU5oGSx6g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, patch applied.

On Wed, Apr 29, 2020 at 1:29 PM Khushboo Vashi <
khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:

> Hi Navnath,
>
> On Wed, Apr 29, 2020 at 12:16 PM navnath gadakh <
> navnath(dot)gadakh(at)enterprisedb(dot)com> wrote:
>
>> Hi Khushboo,
>>
>> Patch looks good to me except there are no API test cases written for
>> dependents and dependencies.
>>
>> Thanks for the review.
> We don't have API test cases for dependents and dependencies for none of
> the objects.
> If the team agrees, I will create a separate RM for that.
>
> Thanks,
> Khushboo
>
>> Thanks!
>>
>> On Wed, Apr 29, 2020 at 10:40 AM navnath gadakh <
>> navnath(dot)gadakh(at)enterprisedb(dot)com> wrote:
>>
>>> Hi ,
>>>
>>> I'm reviewing this task.
>>>
>>> On Wed, Apr 29, 2020 at 9:36 AM Khushboo Vashi <
>>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi,
>>>>
>>>> Please find the attached patch to fix the RM 5422 - Synonym
>>>> Dependencies tab shows incorrect data.
>>>>
>>>> Thanks,
>>>> Khushboo
>>>>
>>>
>>>
>>> --
>>> Regards,
>>> Navnath Gadakh
>>>
>>
>>
>> --
>> Regards,
>> Navnath Gadakh
>>
>

--
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2020-05-04 07:54:42 Re: [pgAdmin][RM4279] : Issue with File Browser Home button
Previous Message Akshay Joshi 2020-05-04 07:54:00 pgAdmin 4 commit: Gracefully informed the user that the database is alr