| From: | Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com> |
|---|---|
| To: | navnath gadakh <navnath(dot)gadakh(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin4][Patch] - RM 5422 - Synonym Dependencies tab shows incorrect data |
| Date: | 2020-04-29 07:59:08 |
| Message-ID: | CAFOhELea0iMpt_zJdZ1-h0sTJ1Kcc8cmM31Vpz3XfcsRik2-Sw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi Navnath,
On Wed, Apr 29, 2020 at 12:16 PM navnath gadakh <
navnath(dot)gadakh(at)enterprisedb(dot)com> wrote:
> Hi Khushboo,
>
> Patch looks good to me except there are no API test cases written for
> dependents and dependencies.
>
> Thanks for the review.
We don't have API test cases for dependents and dependencies for none of
the objects.
If the team agrees, I will create a separate RM for that.
Thanks,
Khushboo
> Thanks!
>
> On Wed, Apr 29, 2020 at 10:40 AM navnath gadakh <
> navnath(dot)gadakh(at)enterprisedb(dot)com> wrote:
>
>> Hi ,
>>
>> I'm reviewing this task.
>>
>> On Wed, Apr 29, 2020 at 9:36 AM Khushboo Vashi <
>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>
>>> Hi,
>>>
>>> Please find the attached patch to fix the RM 5422 - Synonym Dependencies
>>> tab shows incorrect data.
>>>
>>> Thanks,
>>> Khushboo
>>>
>>
>>
>> --
>> Regards,
>> Navnath Gadakh
>>
>
>
> --
> Regards,
> Navnath Gadakh
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Murtuza Zabuawala | 2020-04-29 08:56:00 | [pgAdmin4] RESQL tests for Column & Type nodes |
| Previous Message | navnath gadakh | 2020-04-29 06:45:52 | Re: [pgAdmin4][Patch] - RM 5422 - Synonym Dependencies tab shows incorrect data |