| From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
|---|---|
| To: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>, Dave Page <dave(dot)page(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin4][RM3849] Ask to save unsaved query changes stopped working |
| Date: | 2019-01-22 06:27:16 |
| Message-ID: | CANxoLDciA484H5RMwbL3Nn+PudGFYxa_jjRnQnXsmYoPeOKxQw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi Aditya
Below are my review comments:
- You have added new config parameter "*DISABLE_BEFOREUNLOAD_MESSAGE*"
to make this request configurable, should it be the part of preferences
setting instead of configuration? @Dave can you please comment on this.
- Name "*DISABLE_BEFOREUNLOAD_MESSAGE"* is not clear as users
perspective, can you please change it to some meaningful name.
Apart from that code looks good to me.
On Mon, Jan 21, 2019 at 1:24 PM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
> Hi Hackers,
>
> Attached is the patch to throw alert warning when user reloads or closes
> the browser.
>
> Kindly review.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"
>
--
*Akshay Joshi*
*Sr. Software Architect *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Murtuza Zabuawala | 2019-01-22 06:51:01 | Re: [pgAdmin4][Patch]: RM - 3051 - ables > Properties > Columns tab is slow on tables with a lot of fields |
| Previous Message | Aditya Toshniwal | 2019-01-22 06:03:05 | Re: [pgAdmin4][Patch]: RM - 3051 - ables > Properties > Columns tab is slow on tables with a lot of fields |