Re: [pgAdmin4][Patch]: RM - 3051 - ables > Properties > Columns tab is slow on tables with a lot of fields

Hi Khushboo,

I have few suggestions/review:
1) Do we need to add "editor" class to switch control in backgrid when
changing. For eg. in tables->columns if I change not null switch, it adds
editor class which makes hover background white. Plus, leaving the switch
does not remove editor class. I think we can skip adding editor, what
do you think?
2) In Login roles, Create trigger dialogs switch control colors are
different. Below is screenshot,
[image: Screenshot 2019-01-22 at 11.04.36 AM.png]
3) In Create cast dialog switch control is smaller and so clipping text.
Below is screenshot,
[image: Screenshot 2019-01-22 at 11.07.14 AM.png]
4) You've removed unnecessary switch control template codes at most places.
I would suggest doing the same for Backform.CustomSwitchControl in
trigger.js
5) Feature tests are still using bootstrap-switch classes and so failing.

Apart from above, everything looks good to me.

On Mon, Jan 21, 2019 at 4:42 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:

> Hi Aditya
>
> Can you please review it.
>
> On Mon, Jan 14, 2019 at 4:28 PM Khushboo Vashi <
> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> Please find the attached patch to fix #3051 - Tables > Properties >
>> Columns tab is slow on tables with a lot of fields
>>
>> The root cause of the issue is bootstrap switch, which has been replaced
>> with bootstrap4-toggle application wide.
>>
>> Thanks,
>> Khushboo
>>
>
>
> --
> *Akshay Joshi*
>
> *Sr. Software Architect *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>

--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"